Update auf 5.7.2 Fehler bei Filterund Uncaught SyntaxError: JSON.parse

Michael_Telgmann · 3. November 2021 um 06:50

Hallo zusammen,

könntet ihr mal schauen, ob dieser Pull Request auf GitHub euer Problem löst?

github.com/shopware/shopware

Fix widgets/listing/listingCount for facets containing html tags

shopware:5.7 ← Nevay:fix/listing-count-returns-invalid-json

opened 11:32AM - 26 Oct 21 UTC

Nevay

+1 -1

### 1. Why is this change necessary? widgets/listing/listingCount returns broken json if `$facets` contains html tags. ### 2. What does this change do, exactly? HTML-escapes the json-encoded facets. ### 3. Describe each step to reproduce the issue or behaviour. Config: \- enable ES Plugins: \- TestPlugin (see below, alternatively use SwagEnterpriseSearch and test on search listing) Backend settings: \- enable filter_ajax_reload <details> <summary>TestPlugin/TestPlugin.php</summary> ```php <?php namespace TestPlugin; use Shopware\Bundle\SearchBundle\Criteria; use Shopware\Bundle\SearchBundle\FacetResultInterface; use Shopware\Bundle\SearchBundle\ProductNumberSearchResult; use Shopware\Bundle\SearchBundleES\ResultHydratorInterface; use Shopware\Bundle\StoreFrontBundle\Struct\ShopContextInterface; use Shopware\Components\Plugin; use Symfony\Component\DependencyInjection\ContainerBuilder; class TestPlugin extends Plugin { public function build(ContainerBuilder $container) { parent::build($container); $container->register(TestHydrator::class) ->addTag('shopware_search_es.search_handler') ; } } class TestHydrator implements ResultHydratorInterface { public function hydrate(array $elasticResult, ProductNumberSearchResult $result, Criteria $criteria, ShopContextInterface $context) { $result->addFacet(new class implements FacetResultInterface { public string $_ = '<b>'; public function getFacetName() { return self::class; } public function isActive() { return false; } public function getLabel() { return self::class; } public function getTemplate() { return null; } }); } } ``` </details> Steps: \- Open category or search listing (e.g. `/genusswelten/?p=1`) \- Apply one of the available filters (e.g. "Farbe" "goldig") Page hangs at reloading, caused by broken json in `#facets` due to `<b>` tag. ### 6. Checklist - [ ] I have written tests and verified that they fail without my change - [X] I have squashed any insignificant commits - [ ] This change has comments for package types, values, functions, and non-obvious lines of code - [X] I have read the contribution requirements and fulfil them.

Viele Grüße aus Schöppingen
Michael Telgmann

Thema		Antworten	Aufrufe
Shopware Update Error Allgemein	7	1002	13. September 2016
Update auf 5.4 schlägt fehl - Shop und Backend im Wartungsmodus Allgemein	2	476	5. März 2018
Fehlermeldung bei Datenbank importieren Installation/Einstieg	0	345	13. Oktober 2015
Update auf 5.0.3. funktioniert nicht Administration	1	693	7. September 2015
Update 5.5.4 -> 5.5.6 -> Datenbank Update bricht ab, Backend und Frontend nicht erreichbar Allgemein	2	703	7. Februar 2019

Update auf 5.7.2 Fehler bei Filterund Uncaught SyntaxError: JSON.parse

Verwandte Themen