# Auto code review - errors found on "finally" but code is OK

**URL:** <https://forum.shopware.com/t/auto-code-review-errors-found-on-finally-but-code-is-ok/52507>\
**Category:** Plugins\
**Created:** [20. April 2018 um 15:52 UTC](https://forum.shopware.com/t/auto-code-review-errors-found-on-finally-but-code-is-ok/52507 "2018-04-20T15:52:27Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![Jon2018](https://avatars.discourse-cdn.com/v4/letter/j/8e8cbc/32.png) [@Jon2018](https://forum.shopware.com/u/Jon2018)\
**Post date:** [20. April 2018 um 15:52 UTC](https://forum.shopware.com/t/auto-code-review-errors-found-on-finally-but-code-is-ok/52507/1 "2018-04-20T15:52:27Z")

</div>

Hi,&nbsp;  
I tried to upload our&nbsp;latest plugin (YOOCHOOSE Personalization for Shopware / [https://account2.shopware.com/producer/plugins/2619](https://account2.shopware.com/producer/plugins/2619) ) version v2.5.4 but auto code review failed, reporting:

> Parse error: syntax error, unexpected ‚{‘ in /Frontend/YoochooseJsTracking/Controllers/Frontend/Yctrigger.php on line 60  
> Errors parsing /Frontend/YoochooseJsTracking/Controllers/Frontend/Yctrigger.php

This is the finally part of a try/catch/finally block. It is legal and should not fail, I think.

It works in out DEV and PROD systems shopware v5.3.7  
I tested the file on this site and from php versions \>= v5.5.38 it worked fine. No syntax errors.  
Since the minimum requirements for shopware are php \>= 5.6.4, I would not expect this auto code review to fail.

&nbsp;

I have another question:&nbsp; how can we make a preliminary check that our plugin is compatible with shopware v 5.4?&nbsp;can we just select that version in the upoad page and then try to make the upload that code review will test it?&nbsp;Or is there a validation tool available?  
Please advise.

Best regards

---

<div class="post-metadata">

**Author:** ![Jon2018](https://avatars.discourse-cdn.com/v4/letter/j/8e8cbc/32.png) [@Jon2018](https://forum.shopware.com/u/Jon2018)\
**Post date:** [23. April 2018 um 07:28 UTC](https://forum.shopware.com/t/auto-code-review-errors-found-on-finally-but-code-is-ok/52507/2 "2018-04-23T07:28:47Z")

</div>

“I tested the file on this site” -\>&nbsp;[PHP code syntax check](https://www.piliapp.com/php-syntax-check/) (I forgot to paste the site)